Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP_MinusInfty > 0 returns True #11

Closed
nibrunie opened this issue Aug 21, 2018 · 2 comments
Closed

FP_MinusInfty > 0 returns True #11

nibrunie opened this issue Aug 21, 2018 · 2 comments
Assignees
@nibrunie
Labels
bug Something isn't working

Comments

@nibrunie
Copy link
Contributor

Comparisons of core.special_values such as signed infinities return erroneous results
when compared with numerical values:

from metalibm_core.core.special_values import FP_MinusInfty
from metalibm_core.core.ml_formats import ML_Binary32

print(FP_MinusInfty(ML_Binary32) > 0)
@nibrunie nibrunie added the bug Something isn't working label Aug 21, 2018
@nibrunie
Copy link
Contributor Author

Partially fixed in 986e37f
Now comparison raise NotImplementedError

@nibrunie nibrunie self-assigned this Jan 19, 2020
nibrunie added a commit that referenced this issue Jan 19, 2020
@nibrunie
[#11] fixing special value comparison predicate
576729d 
Details:
* Implementing __lt__ and __eq__ comparison operations for FP_SpecialValue
  and NumericValue classes
nibrunie added a commit that referenced this issue Jan 19, 2020
@nibrunie
[#11] adding unit test for special values predicates
b0be6b9
nibrunie added a commit that referenced this issue Jan 20, 2020
@nibrunie
[#11] fixing special value comparison predicate
5e7efd6 
Details:
* Implementing __lt__ and __eq__ comparison operations for FP_SpecialValue
  and NumericValue classes
nibrunie added a commit that referenced this issue Jan 20, 2020
@nibrunie
[#11] adding unit test for special values predicates
56919f6
nibrunie added a commit that referenced this issue Jan 20, 2020
@nibrunie
[#11] Extending special_values unit test
29c7f4f 
Details:
* Adding FP_MinusInfty > 0 unit test (which was the faulty test case listed
  in #11)
nibrunie added a commit that referenced this issue Feb 8, 2020
@nibrunie
[#11] Extending special_values unit test
38d601c 
Details:
* Adding FP_MinusInfty > 0 unit test (which was the faulty test case listed
  in #11)
nibrunie added a commit that referenced this issue Feb 8, 2020
@nibrunie
[#11] Extending special_values unit test
2fca6f7 
Details:
* Adding FP_MinusInfty > 0 unit test (which was the faulty test case listed
  in #11)
@nibrunie
Copy link
Contributor Author

Fixed by commit 5e7efd6 integrated in master branch
unit test added in commit 56919f6 (also integrated in master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nibrunie nibrunie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nibrunie