add a method to host to retrieve the operational status #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellb
suggested changes
Feb 19, 2019
dhellmann
force-pushed
the
expose-status
branch
from
54ba417
to
ac759d3
Compare
russellb
approved these changes
Feb 19, 2019
Instead of expecting users of the BareMetalHost to understand how to fetch the status from the label, add a method. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
There's no reason to expose SetLabel, so change it to setLabel. This requires adding SetHardwareProfile, which should be there anyway. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann
force-pushed
the
expose-status
branch
from
9b6176a
to
38aa203
Compare
cynepco3hahue
pushed a commit
to cynepco3hahue/baremetal-operator
that referenced
this pull request
Jul 3, 2019
…m-20190702 pull upstream 20190702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of expecting users of the BareMetalHost to understand how to
fetch the status from the label, add a method.
Signed-off-by: Doug Hellmann dhellmann@redhat.com