Do not log startUpdate/endUpdate for non LoadBalancer services

Signed-off-by: Etienne Champetier <echampetier@anevia.com>
metallb · Mar 26, 2021 · de85dc6 · de85dc6
1 parent 9ad25a9
commit de85dc6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/speaker/main.go b/speaker/main.go
@@ -199,13 +199,13 @@ func (c *controller) SetBalancer(l gokitlog.Logger, name string, svc *v1.Service
 		return c.deleteBalancer(l, name, "serviceDeleted")
 	}
 
-	l.Log("event", "startUpdate", "msg", "start of service update")
-	defer l.Log("event", "endUpdate", "msg", "end of service update")
-
 	if svc.Spec.Type != "LoadBalancer" {
 		return c.deleteBalancer(l, name, "notLoadBalancer")
 	}
 
+	l.Log("event", "startUpdate", "msg", "start of service update")
+	defer l.Log("event", "endUpdate", "msg", "end of service update")
+
 	if c.config == nil {
 		l.Log("event", "noConfig", "msg", "not processing, still waiting for config")
 		return k8s.SyncStateSuccess