Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website updates with a new patch release before container images are built #144

Closed
danderson opened this issue Jan 17, 2018 · 1 comment
Closed
Assignees

Comments

@danderson
Copy link
Contributor

Is this a bug report or a feature request?:

bug

What happened:

Website is currently pinned to a minor version branch, e.g. v0.3. This means that as soon as I push the tag for a new patch version, the website updates to that patched version. Notably, it tells people to apply manifests that use the new patch version in manifests... But CircleCI only starts building the images when I push, so for a 5-30min window after the push, we're advertising manifests that will crashloop with ImagePullError.

What you expected to happen:

Website should always point to manifests that work.

@danderson
Copy link
Contributor Author

Hrm, no obviously good way to make this happen. Netlify doesn't support making the main deploy be from a tag, so as soon as I push the updates on the v0.X branch, the website updates.

I think the next best thing is: create a live-website branch, which netlify always deploys as the main site. Then, on each release, after pushing the v0.X branch and letting CircleCI build appropriate images, do a git branch -f live-website v0.X and repush the branch ref to trigger the website deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant