Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm option for priorityClassName #995

Closed
jpuskar opened this issue Oct 16, 2021 · 2 comments · Fixed by #1099
Closed

helm option for priorityClassName #995

jpuskar opened this issue Oct 16, 2021 · 2 comments · Fixed by #1099
Labels

Comments

@jpuskar
Copy link

jpuskar commented Oct 16, 2021

Hi,
It would be great if the helm chart allowed priorityClassName to be set for the controller and speakers.

e.g.

spec:
  template:
    spec:
      priorityClassName: system-node-critical

Here's an example from another chart:
https://github.com/jetstack/cert-manager/blob/master/deploy/charts/cert-manager/templates/webhook-deployment.yaml#L44

@russellb russellb added the helm label Oct 27, 2021
@russellb
Copy link
Collaborator

cc @gclawes

@gclawes
Copy link
Collaborator

gclawes commented Oct 27, 2021

Do we want the option for separate priority classes between speaker and controller? That fits with the other options we have under .Values.controller and .Values.speaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants