Allow specification of priorityClassName for speaker and controller #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk>
ianroberts
requested review from
fedepaol,
johananl,
rata and
russellb
as code owners
|
Not sure why the tests are failing, I haven't touched anything that would affect the tests as installing with the stock |
yes we have a couple of flakes we are chasing. The do not seem related. |
|
cc @gclawes |
|
LGTM. Thanks for adding the validations, too! |
sabinaaledort
pushed a commit
to sabinaaledort/metallb
that referenced
this pull request
Dec 8, 2021
…etallb#1099) Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk> Co-authored-by: Federico Paolinelli <fpaoline@redhat.com>
rata
pushed a commit
to kinvolk/metallb
that referenced
this pull request
Feb 17, 2022
…etallb#1099) Signed-off-by: Ian Roberts <i.roberts@dcs.shef.ac.uk> Co-authored-by: Federico Paolinelli <fpaoline@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing using the plain manifests you can add a
priorityClassNameto the speaker and controller pods via a kustomization, but there's currently no way to do the same when installing via helm. This PR adds the necessary snippets to the helm templates to inject these settings via e.g.--set speaker.priorityClassName=system-node-critical, and the equivalent forcontroller.Fixed #995