Bump controller runtime / k8s api #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
force-pushed
the
bump123
branch
13 times, most recently
from
b4f4018
to
44e7f3f
Compare
Following up the updates from dependabot, we bump up the versions of both the pinned k8s api and the version of the controller runtime. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Bump up go version for CI Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This was referenced Mar 25, 2022
liornoy
reviewed
Mar 27, 2022
| - run: | | ||
| curl -o /tmp/go1.17.1.linux-amd64.tar.gz https://dl.google.com/go/go1.17.1.linux-amd64.tar.gz | ||
| sudo rm -rf /usr/local/go | ||
| sudo tar -C /usr/local -xzf /tmp/go1.17.1.linux-amd64.tar.gz |
There was a problem hiding this comment.
how come with go 1.16 we didn't have to curl?
There was a problem hiding this comment.
the issue here is, we are using a vm (as opposed to the docker image for the other lanes) because frr tests are using docker. The version of go that came with it was old and not compatible with our codebase (some of the dependencies, actually).
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the updates from dependabot, we bump up the versions of both the pinned k8s api and the version of the controller runtime.