Validate crd match expressions #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pperiyasamy
requested review from
fedepaol,
johananl,
rata,
russellb,
gclawes and
oribon
as code owners
pperiyasamy
force-pushed
the
label-selector-duplicate
branch
2 times, most recently
from
8e6167d
to
b19880c
Compare
pperiyasamy
changed the title
pperiyasamy
force-pushed
the
label-selector-duplicate
branch
from
b19880c
to
9e78a32
Compare
fedepaol
reviewed
Jun 18, 2022
| @@ -1005,8 +1011,32 @@ func validateDuplicate(strSlice []string, sliceType string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func validateLabelSelectorMatchExpressions(matchExpressions []metav1.LabelSelectorRequirement) error { | |||
There was a problem hiding this comment.
Since this is used in the function below, can we put it after it?
Ideally, higher level functions should come first.
This validates duplicate values specified in node, ip pool selectors match expressions under bgp peer, bgp and l2 advertisements. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
label-selector-duplicate
branch
from
9e78a32
to
7240281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates duplicate values specified in node and ip pool
selectors match expressions under bgp peer, bgp and l2
advertisements.
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com