Restrict RBAC on webhooks and CRDS #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerauerbeck
requested review from
fedepaol,
johananl,
rata,
russellb,
gclawes and
oribon
as code owners
|
I'll take a look at these failing tests. |
tylerauerbeck
force-pushed
the
fix-crd-rbac
branch
from
47cd448
to
4afd09c
Compare
fedepaol
reviewed
Oct 26, 2022
internal/k8s/k8s.go
Outdated
| @@ -354,7 +354,7 @@ func (c *Client) CreateMlSecret(namespace, controllerDeploymentName, secretName | |||
| }, | |||
| metav1.CreateOptions{}) | |||
| if err == nil { | |||
| level.Info(c.logger).Log("op", "CreateMlSecret", "msg", "secret succesfully created") | |||
| level.Info(c.logger).Log("op", "CreateMlSecret", "msg", "secret successfully created") | |||
There was a problem hiding this comment.
How comes this is here? I thought I merged it
There was a problem hiding this comment.
That's a good question. Cleaned this up and looks like it's gone.
|
Looks good (apart from the intruder commit). Just one ask, would you mind squashing? I think it makes sense to have 3 commits here:
|
Updates RBAC template to only allow list access to all webhooks and CRDS, while permitting the original extended access specifically to MetalLB created resources. Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Updates RBAC manifest to only allow list access to all webhooks and CRDS, while permitting the original extended access specifically to MetalLB created resources. Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Generates various flavors of all-in-one manifests using the new RBAC configuration to restrict RBAC access to MetalLB resources. Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
tylerauerbeck
force-pushed
the
fix-crd-rbac
branch
from
fad5128
to
775a13d
Compare
|
@fedepaol Cleaned this up like you asked. Should be good to go once CI passes. |
|
Awesome, I have a few other prs below this, rebasing, waiting for CI and merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts the ability to make changes to CRDS and webhooks to only specific CRDS and webhooks deployed by MetalLB.
Fixes #1641