remove io/ioutil for advanced golang #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yanggang <gang.yang@daocloud.io>
yanggangtony
requested review from
fedepaol,
johananl,
rata,
russellb,
gclawes and
oribon
as code owners
|
Thanks 😍 |
|
Looks good! thanks @yanggangtony !! |
|
😄 |
|
I'll merge it when I get to it. I am trying to follow a fifo approach and there was a bit of backlog, sorry about that. |
@fedepaol thanks for reply.. |
|
Thanks and sorry again for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yanggang gang.yang@daocloud.io
We should clean all io/util package according the url: https://go.dev/doc/go1.16#ioutil
/kind cleanup