L2: avoid having one failure on responder disable l2 #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a responder cannot be created on a given interface, it should not prevent responders to be created on all the other interfaces. For this reason here we continue instead of returning. This is even more sensible with the interface selector mechanism, because returning won't allow the list of interfaces to be filled and so the speaker will always skip. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
If the flag is set, we don't need to iterate over the interfaces to find a match because it will always be the case. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
requested review from
rata,
russellb,
gclawes and
oribon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a responder fails to be set (i.e. ndp on a ipv4 only node), then the list of interfaces is not being built.
That results in l2 mode entirely not working. Here we make the mechanism a bit more robust by continuing on errors.
Fixes #1727