Add a liveness probe to the frr container #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the proliferation of the frr related tools that are starting to pullute the root folder, we move all the frr addons under frr-tools. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
requested review from
rata,
russellb,
gclawes and
oribon
as code owners
oribon
reviewed
Dec 6, 2022
config/manifests/metallb-frr.yaml
Outdated
| exec: | ||
| command: | ||
| - /etc/frr_liveness/liveness.sh | ||
| initialDelaySeconds: 5 |
There was a problem hiding this comment.
this seems a bit short ( as a guess ), is there a reason you went with 5 seconds?
also a startupprobe might be more fitting, wdyt?
There was a problem hiding this comment.
yeah, it makes sense. Will change
liornoy
reviewed
Dec 6, 2022
| startupProbe: | ||
| exec: | ||
| command: ["/etc/frr_liveness/liveness.sh"] | ||
| failureThreshold: 30 |
There was a problem hiding this comment.
is it 30 on purpose here? or should it be 3? i.e. like in the livenessProbe
liornoy
reviewed
Dec 6, 2022
| initialDelaySeconds: 5 | ||
| periodSeconds: 5 |
There was a problem hiding this comment.
Shouldn't this be:
periodSeconds: 5
failureThreshold: 3
like in different places in the code?
There was a problem hiding this comment.
yeah that's the old version, good catch
There are corner case, after node reboots, where the speaker is still running but the frr processes are not. Here we add a liveness probe that verifies all the daemons are running so the container gets restarted if one of them died. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
|
LGTM, also tested on my Kind cluster and works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make sure that frr is up and running, we add a liveness probe to check that the daemons are available.