Enable adding of additional Labels to speaker+controller #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerFels
requested review from
fedepaol,
rata,
russellb,
gclawes and
oribon
as code owners
|
This PR has been automatically marked as stale because it has been open 30 days
|
|
@fedepaol could you please take a look? |
| @@ -6,6 +6,11 @@ metadata: | |||
| labels: | |||
| {{- include "metallb.labels" . | nindent 4 }} | |||
| app.kubernetes.io/component: controller | |||
| {{- if .Values.controller.additionalLabels }} | |||
There was a problem hiding this comment.
I don't think you need this check. If I remember well, "with" and "range" do not generate output if the array is empty.
There was a problem hiding this comment.
Thanks @mlguerrero12 , I wasn't aware of this!
fedepaol
reviewed
Mar 14, 2023
fedepaol
reviewed
Mar 14, 2023
|
/lgtm |
|
@DerFels please run inv helmdocs to regenerate the helm docs (ci is annoying but prevents errors :-) ) |
Done :) |
fedepaol
force-pushed
the
add-labels-helm-chart
branch
from
6311acf
to
303b731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Metallb Team,
we have several labels that we like to add to our k8s resources. Some are purely for humans, while others are technically relevant (f.e. tracing, NetworkPolicies).
I noticed that your helm chart does not offer this functionality, so I wanted to help by adding a little code that enables users to specify additionaLabels in the values.yaml which will be picked up by the speaker+controller Daemonsets.
If there is anything missing or you disagree with the solution, I'm always open to feedback :)
Also: Thanks for providing a helm chart in the first place!