Skip to content

chore: fix kustomize v5 deprecations #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fedepaol merged 2 commits into from
Jun 22, 2023
Merged

chore: fix kustomize v5 deprecations #1986

fedepaol merged 2 commits into from
Jun 22, 2023

Conversation

@pmalek
Copy link
Contributor

@pmalek pmalek commented Jun 20, 2023

Related: #1985

@pmalek pmalek mentioned this pull request Jun 20, 2023
Closed
@pmalek pmalek force-pushed the kustomize-v5-fix branch from e95edbf to 5a39e6e Compare June 20, 2023 14:01
pmalek added 2 commits June 20, 2023 16:24
@pmalek
chore: fix kustomize v5 patchesJson6902 deprecation
3adb0c3 
Signed-off-by: Patryk Małek <malekpatryk+github@gmail.com>
@pmalek
chore: fix kustomize v5 patchesStrategicMerge deprecation
eec9986 
Signed-off-by: Patryk Małek <malekpatryk+github@gmail.com>
@pmalek pmalek force-pushed the kustomize-v5-fix branch from 5a39e6e to eec9986 Compare June 20, 2023 14:24
@pmalek pmalek marked this pull request as ready for review June 21, 2023 12:17
@pmalek
Copy link
Contributor Author

pmalek commented Jun 22, 2023

CI / e2e (dual, native, helm, enabled) (pull_request) seem to be broken for some reason 🤔

Can we do something about it and get this merged?

@fedepaol
Copy link
Member

fedepaol commented Jun 22, 2023

CI / e2e (dual, native, helm, enabled) (pull_request) seem to be broken for some reason thinking

Can we do something about it and get this merged?

yep, restarted the job and sent to the merge queue. Thanks for the help!

@fedepaol fedepaol enabled auto-merge June 22, 2023 10:34
@fedepaol fedepaol added this pull request to the merge queue Jun 22, 2023
Merged via the queue into metallb:main with commit cb3bcb8 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol fedepaol is a code owner

@rata rata Awaiting requested review from rata

@russellb russellb Awaiting requested review from russellb

@gclawes gclawes Awaiting requested review from gclawes

@oribon oribon Awaiting requested review from oribon oribon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmalek @fedepaol