Skip to content

Change 'interface to exclude' log level - #1992

Merged
fedepaol merged 1 commit into
metallb:mainfrom
liornoy:change-announcer-log-level
Jul 4, 2023
Merged

fedepaol merged 1 commit into
metallb:mainfrom
liornoy:change-announcer-log-level

Conversation

@liornoy

@liornoy liornoy commented Jul 1, 2023 •

Copy link
Copy Markdown
Contributor

This commit changes the log level from Info to Debug as this log is called every 10 seconds and spams/bloats the speaker's logs.

See example:

{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:51:00Z"}

This commit changes the log level from Info to Debug
as this log is called every 10 seconds and spams the logs.

Signed-off-by: liornoy <lnoy@redhat.com>
@fedepaol
fedepaol added this pull request to the merge queue Jul 4, 2023
@fedepaol

fedepaol commented Jul 4, 2023

Copy link
Copy Markdown
Member

Thanks!

Merged via the queue into metallb:main with commit ca4eed3 Jul 4, 2023
@liornoy
liornoy deleted the change-announcer-log-level branch July 10, 2023 14:15
cfergs added a commit to cfergs/kubernetes-homelab that referenced this pull request Sep 15, 2023
As a bonus stops spamming logs with "announced interface to exclude" - metallb/metallb#1992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants