Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'interface to exclude' log level #1992

Merged
merged 1 commit into from Jul 4, 2023
Merged

Change 'interface to exclude' log level #1992

merged 1 commit into from Jul 4, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented Jul 1, 2023 •
edited

This commit changes the log level from Info to Debug as this log is called every 10 seconds and spams/bloats the speaker's logs.

See example:

{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:49:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:10Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:20Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:30Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:40Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:50:50Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"lo","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth9d893234","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth1d7c0ce9","level":"info","ts":"2023-07-01T12:51:00Z"}
{"caller":"announcer.go:76","event":"announced interface to exclude","interface":"veth940dd62c","level":"info","ts":"2023-07-01T12:51:00Z"}

@liornoy
Change 'interface to exclude' log level
bc5f238 
This commit changes the log level from Info to Debug
as this log is called every 10 seconds and spams the logs.

Signed-off-by: liornoy <lnoy@redhat.com>
@fedepaol fedepaol added this pull request to the merge queue Jul 4, 2023
@fedepaol
Copy link
Member

fedepaol commented Jul 4, 2023

Thanks!

Merged via the queue into metallb:main with commit ca4eed3 Jul 4, 2023
25 checks passed
@liornoy liornoy deleted the change-announcer-log-level branch July 10, 2023 14:15
cfergs added a commit to cfergs/kubernetes-homelab that referenced this pull request Sep 15, 2023
@cfergs
feat(metallb): upgrade to v 0.13.11
b197ad6 
As a bonus stops spamming logs with "announced interface to exclude" - metallb/metallb#1992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol fedepaol is a code owner

@rata rata Awaiting requested review from rata

@russellb russellb Awaiting requested review from russellb russellb is a code owner

@gclawes gclawes Awaiting requested review from gclawes gclawes is a code owner

@oribon oribon Awaiting requested review from oribon oribon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liornoy @fedepaol