Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more livenessProbe configurability in helm chart for frr container #2034

Merged
merged 2 commits into from Aug 23, 2023

Conversation

PeterGrace
Copy link
Contributor

This PR implements the additional fields available to a livenessProbe for the frr container. The rationale is that I run k8s nodes on SOQuartz arm64 boards and they sometimes can take >1 second to respond to livenessProbe queries. Because the fields were previously undefined, timeoutSeconds was defaulting to 1, leading to the frr container falling into CrashLoopBackOff.

@PeterGrace PeterGrace changed the title add more livenessProbe configurability to frr add more livenessProbe configurability in helm chart for frr container Aug 4, 2023
Signed-off-by: Peter Grace <pete.grace@gmail.com>
@fedepaol
Copy link
Member

mind squashing the commits?

@PeterGrace PeterGrace force-pushed the petergrace_frr_timeout_chart_change branch from 7fa4ff7 to 2a609b6 Compare August 21, 2023 11:07
@PeterGrace
Copy link
Contributor Author

mind squashing the commits?

Hi @fedepaol , I've squashed the commits which should be reflected in 2a609b6.

I see the CI shows some unit test and static analysis errors, I don't think that this change would impact those but let me know if I need to do some further investigation there. Thanks!

@fedepaol
Copy link
Member

mind squashing the commits?

Hi @fedepaol , I've squashed the commits which should be reflected in 2a609b6.

I see the CI shows some unit test and static analysis errors, I don't think that this change would impact those but let me know if I need to do some further investigation there. Thanks!

yep, the failure is not related to this change (and it was already addressed).
LGTM, thanks!

@fedepaol fedepaol added this pull request to the merge queue Aug 23, 2023
Merged via the queue into metallb:main with commit 04abf80 Aug 23, 2023
25 checks passed
@PeterGrace PeterGrace deleted the petergrace_frr_timeout_chart_change branch August 23, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants