make webhook secret's name configurable #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
requested review from
fedepaol,
russellb,
gclawes and
oribon
as code owners
cyclinder
force-pushed
the
webhook_secret_name
branch
from
5c2c8cc
to
3a327f8
Compare
It appears that webhookSecretName is hardcoded to 'webhook-server-cert', With this PR, we can configure it via the controller's flag: --webhook-secret. Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
webhook_secret_name
branch
from
3a327f8
to
35559c7
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that webhookSecretName is hardcoded to 'webhook-server-cert', With this PR, we can configure it via the controller's flag: --webhook-secret.
Fixes: #1993