FRR templates: provide a seqnum for the prefix lists #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
reviewed
Sep 12, 2023
Comment on lines
14
to
15
| route-map 10.2.2.254-out permit 1 | ||
| match ip address prefix-list 10.2.2.254-red-pl-ipv4 |
There was a problem hiding this comment.
this looks out of place (shouldn't this be red-out)?
Comment on lines
26
to
29
| route-map 10.4.4.255-out permit 1 | ||
| match ip address prefix-list 10.4.4.255-red-pl-ipv4 | ||
| route-map 10.4.4.255-red-out permit 1 | ||
| match ipv6 address prefix-list 10.4.4.255-red-pl-ipv4 |
fedepaol
force-pushed
the
prefixseqnum
branch
2 times, most recently
from
605c48b
to
4b0a587
Compare
oribon
reviewed
Sep 12, 2023
| ipv6 prefix-list {{$plistName}} seq {{counter $plistName}} deny any | ||
| {{- end }} | ||
|
|
||
| route-map {{$.neighbor.ID}}-out permit {{counter $.neighbor.Addr}} |
There was a problem hiding this comment.
counter $.neighbor.Addr -> $.neighbor.ID
fedepaol
force-pushed
the
prefixseqnum
branch
2 times, most recently
from
350e650
to
792e3c1
Compare
Instead of letting frr pick the sequence number, we provide it from outside. This should make the configuration more deterministic and offload some of the logic from FRR. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
prefixseqnum
branch
from
792e3c1
to
69255c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting frr pick the sequence number, we provide it from outside. This should make the configuration more deterministic and offload some of the logic from FRR.