Skip to content

Add support for speaker securityContext#2099

Merged
fedepaol merged 1 commit intometallb:mainfrom
mjnagel:helm-speaker-configurability
Oct 16, 2023
Merged

Add support for speaker securityContext#2099
fedepaol merged 1 commit intometallb:mainfrom
mjnagel:helm-speaker-configurability

Conversation

@mjnagel
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel commented Oct 2, 2023

Small addition to support setting the pod level security context on the speaker daemonset.

This is useful in some environments where explicit securityContext must be set for pods, or potentially when using a rebuilt image with a different (user/group could be different).

@mjnagel
Copy link
Copy Markdown
Contributor Author

mjnagel commented Oct 3, 2023

Not sure why the one e2e test is failing - my changes didn't affect the manifests and shouldn't have even effected the default helm behavior.

@fedepaol
Copy link
Copy Markdown
Member

fedepaol commented Oct 9, 2023

Not sure why the one e2e test is failing - my changes didn't affect the manifests and shouldn't have even effected the default helm behavior.

probably a flake (we got some of them, although quite rarely).
Would you mind aligning the value.schema.json file too?

Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
@mjnagel
Copy link
Copy Markdown
Contributor Author

mjnagel commented Oct 11, 2023

@fedepaol done - just left as an object in the schema. Happy to add the properties but it didn't seem like other things were that verbose in the schema. Let me know if you want any adjustments.

@fedepaol
Copy link
Copy Markdown
Member

@fedepaol done - just left as an object in the schema. Happy to add the properties but it didn't seem like other things were that verbose in the schema. Let me know if you want any adjustments.

yep makes sense, thanks!

@fedepaol fedepaol added this pull request to the merge queue Oct 16, 2023
Merged via the queue into metallb:main with commit 384af99 Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants