Allow custom bind address for memberlist #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rablet
requested review from
fedepaol,
russellb,
gclawes and
oribon
as code owners
|
@Rablet need to update the helm docs, please run |
Signed-off-by: Robin <hi@rablet.dev>
|
I believe I have done this now - please let me know if this is not the case! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bind address for memberlist is currently always set to the pod's IP address:
- name: METALLB_ML_BIND_ADDR valueFrom: fieldRef: fieldPath: status.podIPThis PR allows this to be customised.
In my scenario I wanted it to listen to a different address as the speaker pods were connecting to each other via a VIP which didn't work unless I changed the bind address.
The current behaviour is kept as the default behaviour, but it can be overridden using the new
speaker.memberlist.mlBindAddrOverrideconfiguration in values.yaml.