Speaker: Allow configuring MemberList timeouts for WAN environments #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbasov
requested review from
fedepaol,
russellb,
gclawes and
oribon
as code owners
fedepaol
reviewed
Nov 30, 2023
|
@pbasov mind changing the commit body to explain the rationale behind the change (basically what you put in the pr text) |
- In WAN environments timeouts and intervals for Probes and Gossip in Memberlist can be too tight, since MetalLB uses DefaultLANConfig by default. - New speaker.wanConfig value for the chart allows setting new flag to select DefaultWANConfig "preset" for MemberList instead. Signed-off-by: Pavel Basov <pbasov@mirantis.com>
|
fedepaol Updated with your suggestions, PTAL |
|
thanks, sending to merge queue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WAN environments timeouts and intervals for Probes and Gossip in Memberlist can be too tight, since MetalLB uses DefaultLANConfig by default.
This PR allows using DefaultWANConfig instead through a chart value.