New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove endpoint support #2254
Remove endpoint support #2254
Conversation
9e37816
to
079d759
Compare
expectedLBRet: controllers.SyncStateSuccess, | ||
}, | ||
{ | ||
desc: "Multiple advertisement config, one only for my node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this and the next one do not have an epslice one with the same name, just making sure we're good with zapping them
return res, err | ||
} | ||
res = epslices.EpsOrSlices{EpVal: &endpoints, Type: epslices.Eps} | ||
func endPointsForService(ctx context.Context, cl client.Reader, serviceName types.NamespacedName) ([]discovery.EndpointSlice, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to epSlicesForService ?
@@ -8,6 +8,8 @@ weight: 8 | |||
- Remove support for the legacy AddressPool API in favor of IPAddressPools. | |||
Being deprecated for a while we finally stop handling the legacy API and remove it, | |||
IPs can now be allocated to LoadBalancer Services only via IPAddressPool resources. ([PR 2252](https://github.com/metallb/metallb/pull/2252)) | |||
- Drop the support for endpoints and rely on endpoint slices only ([Issue 2253](https://github.com/metallb/metallb/issues/2253), [PR 2254](https://github.com/metallb/metallb/pull/2254)) | |||
**NOTE:** this will make metallb not compatible with clusters older than 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: metallb -> MetalLB
079d759
to
3f87770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Endpoint slices is supported since k8s 1.21, it's sane to remove the endpoint support and all the duplicated code, and rely on ep slices only. This would simplify the codebase making it more maintainable. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
When we destroy the cluster with kind delete cluster, the network2 network remains dangling and a sequent inv dev-env command will fail to create it. Here we don't create if it exists already. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
3f87770
to
e8741e0
Compare
Endpoint slices is supported since k8s 1.21, it's sane to remove the endpoint support and all the duplicated code, and rely on ep slices only.