Repository navigation
Remove endpoint support - #2254
Merged
Merged
Conversation
fedepaol
force-pushed
the
removeendpointsupport
branch
3 times, most recently
from
January 23, 2024 21:25
9e37816 to
079d759
Compare
oribon
reviewed
Jan 25, 2024
| expectedLBRet: controllers.SyncStateSuccess, | ||
| }, | ||
| { | ||
| desc: "Multiple advertisement config, one only for my node", |
Member
There was a problem hiding this comment.
nit: this and the next one do not have an epslice one with the same name, just making sure we're good with zapping them
| return res, err | ||
| } | ||
| res = epslices.EpsOrSlices{EpVal: &endpoints, Type: epslices.Eps} | ||
| func endPointsForService(ctx context.Context, cl client.Reader, serviceName types.NamespacedName) ([]discovery.EndpointSlice, error) { |
Member
There was a problem hiding this comment.
nit: rename to epSlicesForService ?
| Being deprecated for a while we finally stop handling the legacy API and remove it, | ||
| IPs can now be allocated to LoadBalancer Services only via IPAddressPool resources. ([PR 2252](https://github.com/metallb/metallb/pull/2252)) | ||
| - Drop the support for endpoints and rely on endpoint slices only ([Issue 2253](https://github.com/metallb/metallb/issues/2253), [PR 2254](https://github.com/metallb/metallb/pull/2254)) | ||
| **NOTE:** this will make metallb not compatible with clusters older than 1.21 |
fedepaol
force-pushed
the
removeendpointsupport
branch
from
January 25, 2024 09:48
079d759 to
3f87770
Compare
Endpoint slices is supported since k8s 1.21, it's sane to remove the endpoint support and all the duplicated code, and rely on ep slices only. This would simplify the codebase making it more maintainable. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
When we destroy the cluster with kind delete cluster, the network2 network remains dangling and a sequent inv dev-env command will fail to create it. Here we don't create if it exists already. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
removeendpointsupport
branch
from
January 26, 2024 09:27
3f87770 to
e8741e0
Compare
fedepaol
enabled auto-merge
January 26, 2024 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endpoint slices is supported since k8s 1.21, it's sane to remove the endpoint support and all the duplicated code, and rely on ep slices only.