Charts: fix the metrics-certs volume of the speaker#2286
Merged
fedepaol merged 1 commit intometallb:mainfrom Feb 15, 2024
Merged
Charts: fix the metrics-certs volume of the speaker#2286fedepaol merged 1 commit intometallb:mainfrom
fedepaol merged 1 commit intometallb:mainfrom
Conversation
Contributor
|
lgtm, only the pr link is missing in the release notes |
The creation of the metrics-certs volume is conditioned by FRR mode, while it should only be conditioned by the presence of the name of the secret in the values. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
fixspeakervolume
branch
from
61af215 to
1f5cbec
Compare
Member
Author
changed, thanks! |
oribon
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The creation of the metrics-certs volume is conditioned by FRR mode, while it should only be conditioned by the presence of the name of the secret in the values.