Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speaker: hide the L2ServiceStatus generation behind a flag #2312

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Speaker: hide the L2ServiceStatus generation behind a flag #2312

merged 2 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. Speaker: hide the L2ServiceStatus generation behind a flag 

    Because of metallb#2311 we are going
to move the status instances to the metallb namespace. This might
require a change in the permissions too (from cluster to namespaced) so
the new version of MetalLB might not be able to delete the "legacy"
instances of the CRD because they belong to namespaces the new metallb
might not have permissions on.

Because of this, we hide the feature behind a flag, effectively
disabling it until the issue is fixed.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    be4e909 View commit details
    Browse the repository at this point in the history

  2. E2E: put all the l2 service status tests under the L2ServiceStatus label 

    We must be able to skip those tests out until
metallb#2311 is fixed.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c7eab49 View commit details
    Browse the repository at this point in the history