Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in publicly available docs about manifest branch #2332

Closed
wants to merge 1 commit into from
Closed

Fix typo in publicly available docs about manifest branch #2332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/content/installation/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ If you want to deploy MetalLB using the [experimental FRR-K8s mode]({{% relref "
kubectl apply -f https://raw.githubusercontent.com/metallb/metallb/v0.14.3/config/manifests/metallb-frr-k8s.yaml
```

Please do note that these manifests deploy MetalLB from the main development branch. We highly encourage cloud operators to deploy a stable released version of MetalLB on production environments!
These manifests deploy MetalLB from a release branch. Indeed, we highly encourage cloud operators to deploy a stable released version of MetalLB (instead of manifests from the main branch) on production environments!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I finally got here. I think the right approach is just to remove this part as a whole, and it should be reomved from the main branch as it is the master where we generate all the versioned release notes using this script

metallb/tasks.py

Line 707 in 25f1bbc

def bumprelease(ctx, version, previous_version):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fedepaol, so do you mean to remove the line 78 entirely ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, as it sounds like a legacy bit from where we were not replacing main with the right tag after a release.


{{% /notice %}}

Expand Down
Loading