inv dev-env fails with --protocol=layer2 because ip address error #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lwabish <wubw@pku.edu.cn>
lwabish
requested review from
fedepaol,
russellb,
gclawes and
oribon
as code owners
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
In
tasks.py, functionget_available_ipsreturns string, [0] is redundant and leads to format error when generatingdev-env/layer2/config.yamlMeanwhile, added a
kubectl waitto apply layer2 config after controller pod is ready or the webhook would got aconnection refusederrorSpecial notes for your reviewer:
Release note: