Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump composite workflow actions #2405

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

tylerauerbeck
Copy link
Contributor

Is this a BUG FIX or a FEATURE ?:

/kind cleanup

What this PR does / why we need it:

This PR cleans up the composite workflow(s) action dependency. These are running on fairly old versions of the actions and are throwing the following warnings in CI

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v3, actions/download-artifact@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@tylerauerbeck
Copy link
Contributor Author

Taking a look at the failures 👀

tylerauerbeck and others added 2 commits May 20, 2024 00:49
…patability

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@tylerauerbeck tylerauerbeck deleted the bump-e2e-actions branch May 27, 2024 06:13
@tylerauerbeck tylerauerbeck restored the bump-e2e-actions branch May 28, 2024 02:22
@tylerauerbeck tylerauerbeck reopened this May 28, 2024
@tylerauerbeck
Copy link
Contributor Author

Woops. Accidental cleanup. This should be in good shape once the tests pass (again).

@fedepaol
Copy link
Member

merging, thanks!

@fedepaol fedepaol merged commit 95274d9 into metallb:main May 30, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants