Fix website typos on release process #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to say that I reviewed it, the first commit start with |
We should get the git log output only for the commits since the last release to CUR-BRANCH (that can be main or v0.9, for example, if minor or patch is release is created). When searching the common ancestor (using git merge-base) we look for it between CUR-BRANCH and PREV-TAG. When we retrive the logs, we want the logs from the common ancestor to CUR-BRANCH too, that is why we searched for the common ancestor in the first place.
|
@champtar oh, good catch! Thanks, updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches were created some weeks ago when doing the 0.9.x release, of the random things I noticed I did differently from the release process document.
There is also a simple fix to reference metallb github org in the install instructions. Actions to do that thoroughly are already in progress (#570 and #567), this is just an old patch that I had in my queue.
More details in the commit messages :)