-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository URLs #688
Conversation
I've tested more or less all the links manually and they seem to work. The only thing I couldn't test is the https://github.com/metallb/metallb/pull/688/files#diff-dc31105b816206de63c47bf42ec2a4d7R302-R304 If we can test this without crafting a release, let's do it and then merge (can we @rata?). If we can't, let's merge as is and fix any problems which may arise as we encounter them. |
lgtm |
@rata do you still have any remaining concerns? If not, I'll go ahead and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested locally with hugo-serve
just in case? Be aware of: #554, though
Yes, I always do on doc changes. |
@rata I'd like to add this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM.
77cfce5
to
e035ce8
Compare
Supersedes #570. Fixes #567.
Opening a new PR as we needed to rebase and I couldn't push to the original branch, likely because the fork no longer exists.