Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository URLs #688

Merged
merged 1 commit into from Nov 6, 2020
Merged

Conversation

johananl
Copy link
Member

@johananl johananl commented Aug 5, 2020

Supersedes #570. Fixes #567.

Opening a new PR as we needed to rebase and I couldn't push to the original branch, likely because the fork no longer exists.

@johananl
Copy link
Member Author

johananl commented Aug 5, 2020

I've tested more or less all the links manually and they seem to work. The only thing I couldn't test is the _replace() function in tasks.py:

https://github.com/metallb/metallb/pull/688/files#diff-dc31105b816206de63c47bf42ec2a4d7R302-R304

If we can test this without crafting a release, let's do it and then merge (can we @rata?). If we can't, let's merge as is and fix any problems which may arise as we encounter them.

@russellb
Copy link
Collaborator

russellb commented Aug 5, 2020

lgtm

@johananl
Copy link
Member Author

johananl commented Aug 5, 2020

@rata do you still have any remaining concerns? If not, I'll go ahead and merge.

Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested locally with hugo-serve just in case? Be aware of: #554, though

tasks.py Show resolved Hide resolved
@johananl
Copy link
Member Author

johananl commented Aug 7, 2020

Have you tested locally with hugo-serve just in case? Be aware of: #554, though

Yes, I always do on doc changes.

@johananl johananl requested a review from rata Nov 4, 2020
@johananl
Copy link
Member Author

johananl commented Nov 4, 2020

@rata I'd like to add this to v0.9.5 since without this change we aren't updating the raw manifests anyway.

rata
rata approved these changes Nov 5, 2020
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM.

@johananl johananl requested a review from rata Nov 5, 2020
@johananl johananl requested a review from daxmc99 as a code owner Nov 6, 2020
@johananl johananl merged commit cf4639e into metallb:main Nov 6, 2020
2 checks passed
@johananl johananl deleted the johananl/repo-urls branch Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace danderson/metallb with metallb/metallb
4 participants