Update repository URLs#688
Merged
Merged
Conversation
Closed
Member
Author
|
I've tested more or less all the links manually and they seem to work. The only thing I couldn't test is the https://github.com/metallb/metallb/pull/688/files#diff-dc31105b816206de63c47bf42ec2a4d7R302-R304 If we can test this without crafting a release, let's do it and then merge (can we @rata?). If we can't, let's merge as is and fix any problems which may arise as we encounter them. |
Contributor
|
lgtm |
Member
Author
|
@rata do you still have any remaining concerns? If not, I'll go ahead and merge. |
Member
Author
Yes, I always do on doc changes. |
Member
Author
|
@rata I'd like to add this to |
johananl
force-pushed
the
johananl/repo-urls
branch
from
77cfce5 to
e035ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #570. Fixes #567.
Opening a new PR as we needed to rebase and I couldn't push to the original branch, likely because the fork no longer exists.