Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetExportSession still exist in memory after cancel #8

Closed
larryonoff opened this issue Jul 15, 2020 · 1 comment · Fixed by #9
Closed

AssetExportSession still exist in memory after cancel #8

larryonoff opened this issue Jul 15, 2020 · 1 comment · Fixed by #9

Comments

@larryonoff
Copy link

During debugging I've observed the following issue.

  1. AssetExportSession.export
  2. AssetExportSession.cancel
  3. maybe repeat 1 and 2 several times.

As result videoInput.requestMediaDataWhenReady(on: self.queue) { [weak self] in line 307 still running, but self = nil.
@larryonoff
Copy link
Author

Maybe you should additionally call self.writer.cancelWriting() cancel method?

@YuAo YuAo mentioned this issue Jul 16, 2020
Merged
@YuAo YuAo closed this as completed in #9 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the lifecycle of AssetExportSession more predictable. MetalPetal/VideoIO
1 participant
@larryonoff