Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences Controller should match against non-public IPs #67

Closed
bdresser opened this issue Mar 11, 2019 · 0 comments
Closed

Preferences Controller should match against non-public IPs #67

bdresser opened this issue Mar 11, 2019 · 0 comments
Assignees
@bitpshr
Labels
security audit

Comments

@bdresser
Copy link

There is a condition in the PreferencesController that checks if the RPC URL is
http://localhost:8545, presumably to check if the node is a local testing node. However, a user may
conceivably run their node on a different port, which would fail this check.
@bitpshr bitpshr self-assigned this Mar 20, 2019
@bitpshr bitpshr mentioned this issue Mar 28, 2019
Merged
@bitpshr bitpshr mentioned this issue Mar 29, 2019
Closed
3 tasks
mcmire pushed a commit to mcmire/core that referenced this issue Jul 17, 2023
@FrederikBolding
Add versions and checksums (MetaMask#67)
a98c035 
* Add versions and checksums

* Add a few more utility functions

* Fix PR comments
kanthesha added a commit that referenced this issue Sep 28, 2023
@github-actions @kanthesha @Gudahtt
5.0.1 (#67)
38c007a 
* 5.0.1

* changelog updated

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
kanthesha pushed a commit that referenced this issue Oct 11, 2023
@rekmarks
Add missing types, fix remaining faulty ones (#67)
c6d49a7 
* Add missing types, fix faulty ones
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@github-actions @kanthesha
@Gudahtt @MajorLift
5.0.1 (#67)
a1ac1bd 
* 5.0.1

* changelog updated

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@github-actions @kanthesha
@Gudahtt @MajorLift
5.0.1 (#67)
93f50b3 
* 5.0.1

* changelog updated

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift pushed a commit that referenced this issue Oct 12, 2023
@github-actions @kanthesha
@Gudahtt @MajorLift
5.0.1 (#67)
52894cc 
* 5.0.1

* changelog updated

* Update CHANGELOG.md

Co-authored-by: Mark Stacey <markjstacey@gmail.com>

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitpshr bitpshr

Labels
security audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitpshr @bdresser