-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences Controller should match against non-public IPs #67
Labels
Comments
3 tasks
mcmire
pushed a commit
to mcmire/core
that referenced
this issue
Jul 17, 2023
* Add versions and checksums * Add a few more utility functions * Fix PR comments
kanthesha
added a commit
that referenced
this issue
Sep 28, 2023
* 5.0.1 * changelog updated * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
kanthesha
pushed a commit
that referenced
this issue
Oct 11, 2023
* Add missing types, fix faulty ones
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
* 5.0.1 * changelog updated * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this issue
Oct 11, 2023
* 5.0.1 * changelog updated * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this issue
Oct 12, 2023
* 5.0.1 * changelog updated * Update CHANGELOG.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Kanthesha Devaramane <kanthesha.devaramane@consensys.net> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a condition in the PreferencesController that checks if the RPC URL is
http://localhost:8545, presumably to check if the node is a local testing node. However, a user may
conceivably run their node on a different port, which would fail this check.
The text was updated successfully, but these errors were encountered: