You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
I'm using json-rpc-engine from a create-react-app, and when building an production minified JS bundle (npm run build), I get an error:
Creating an optimized production build...
Failed to compile.
Failed to minify the code from this file:
./node_modules/json-rpc-engine/src/index.js:5
Read more here: http://bit.ly/2tRViJ9
which says :
Some third-party packages don't compile their code to ES5 before publishing to npm. This often causes problems in the ecosystem because neither browsers (except for most modern versions) nor some tools currently support all ES6 features. We recommend to publish code on npm as ES5 at least for a few more years.
It would be nice to publish a ES5 compiled version of json-rpc-engine (issue related in metamask/mascara)
Many thanks!
The text was updated successfully, but these errors were encountered:
Using exclusively ES5 libraries is no longer recommended by create-react-app, as of v2 I believe. They transpile their dependencies now instead.
As of Babel 7 compiling libraries to ES5 is no longer necessary to support applications that target ES5, because transpiling dependencies is now much easier than it was with Babel 6. See this blog post for more details.
There may have been argument for this in 2017, but as of today, I don't believe that we have plans to continue shipping ES5 builds of any packages we maintain.
Hello,
I'm using
json-rpc-engine
from a create-react-app, and when building an production minified JS bundle (npm run build
), I get an error:which says :
It would be nice to publish a ES5 compiled version of json-rpc-engine (issue related in metamask/mascara)
Many thanks!
The text was updated successfully, but these errors were encountered: