Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap Dialog Prompt : Documentation correction #1198

Closed
mario-christopher opened this issue Mar 8, 2024 · 3 comments · Fixed by #1203
Closed

Snap Dialog Prompt : Documentation correction #1198

mario-christopher opened this issue Mar 8, 2024 · 3 comments · Fixed by #1203
Labels
good first issue Good for newcomers snaps Related to Snaps content. tech-writing Requires updates to documentation content.

Comments

@mario-christopher
Copy link

There is an error in this Page which needs to be corrected.
The dialog type should not have a capital "P" for "Prompt"

image
@alexandratran alexandratran added the good first issue Good for newcomers label Mar 8, 2024
@alexandratran
Copy link
Contributor

Prompt dialog: https://docs.metamask.io/snaps/reference/snaps-api/#prompt-dialog

@mario-christopher Should the alert dialog and confirmation dialog types also not be capitalized?

@alexandratran alexandratran added snaps Related to Snaps content. tech-writing Requires updates to documentation content. labels Mar 8, 2024
@mario-christopher
Copy link
Author

Yes @alexandratran . All should be updated in the Docs to have lower case.

image

@Deepak2030 Deepak2030 mentioned this issue Mar 9, 2024
Merged
@Deepak2030
Copy link
Contributor

Hello, I've raised this PR that solves the above issue. Let me know if it needs any other fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers snaps Related to Snaps content. tech-writing Requires updates to documentation content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1198 snap api doc correction
3 participants
@alexandratran @mario-christopher @Deepak2030