Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1198 snap api doc correction #1203

Merged
merged 5 commits into from
Mar 11, 2024
Merged

1198 snap api doc correction #1203

merged 5 commits into from
Mar 11, 2024

Conversation

DrParadox05
Copy link
Contributor

This resolves #1198 where the dialogue types are changed to lowercase

@DrParadox05 DrParadox05 requested review from a team as code owners March 9, 2024 19:26
@DrParadox05 DrParadox05 mentioned this pull request Mar 9, 2024
Closed
alexandratran
alexandratran requested changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the other snap_dialog code samples in the docs? From a rough search, I found these two that must be updated:

@alexandratran alexandratran merged commit 189f40f into MetaMask:main Mar 11, 2024
8 checks passed
@DrParadox05 DrParadox05 deleted the 1198-snap-api-doc-correction branch March 11, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@Montoya Montoya Montoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snap Dialog Prompt : Documentation correction
3 participants
@DrParadox05 @Montoya @alexandratran