Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions of why the permissions are so extreme in chrome store description #48

Closed
danfinlay opened this issue Mar 10, 2016 · 2 comments
Assignees
Milestone

Comments

@danfinlay
Copy link
Contributor

This plugin requires about as scary-sounding permissions as a chrome extension can ask for, and that is almost definitely going to repulse some users.

What we can do to mitigate that effect is to document and be as transparent as possible about why we require those permissions.

The app store description is one place, I'm not sure if Chrome lets you explain on the permissions screen itself, but we should basically PR bomb why we require permissions as much as possible, so users are prepared for that authorization request.

@danfinlay danfinlay added this to the Public Beta milestone Mar 10, 2016
@kumavis
Copy link
Member

kumavis commented Mar 10, 2016

👍 yeah, need to identify the correct places to do this

@danfinlay danfinlay added ready and removed ready labels Apr 11, 2016
@danfinlay danfinlay self-assigned this Jun 13, 2016
@danfinlay
Copy link
Contributor Author

Updated chrome store description to include this text:

Metamask is an extension for accessing Ethereum enabled distributed applications, or "Dapps" in your normal Chrome browser!

The extension injects the Ethereum web3 API into every website's javascript context, so that dapps can read from the blockchain.

MetaMask also lets the user create and manage their own identities, so when a Dapp wants to perform a transaction and write to the blockchain, the user gets a secure interface to review the transaction, before approving or rejecting it.

Because it adds functionality to the normal browser context, MetaMask requires the permission to read and write to any webpage. You can always "view the source" of MetaMask the way you do any Chrome extension, and we will be publishing our source code soon, to allow public auditing.

danjm pushed a commit that referenced this issue Oct 6, 2020
The `retry` function has been extracted from the
`useSwapSubmitFunction` hook. It has been replaced with an action
creator, `navigateBackToBuildQuote`.

One additional piece of state was cleared, the `approveTxId`. Normally
this wouldn't be set in this circumstance, but if it was it would no
longer be accurate, as it would represent the approval transaction for
a quote that had been cleared from state.
danjm pushed a commit that referenced this issue Oct 6, 2020
The `retry` function has been extracted from the
`useSwapSubmitFunction` hook. It has been replaced with an action
creator, `navigateBackToBuildQuote`.

One additional piece of state was cleared, the `approveTxId`. Normally
this wouldn't be set in this circumstance, but if it was it would no
longer be accurate, as it would represent the approval transaction for
a quote that had been cleared from state.
aloisklink pushed a commit to aloisklink/metamask-extension that referenced this issue Jan 19, 2022
This release includes various dependency updates and development
tooling changes. The only functional change is the upgrade of
`trezor-connect` from v7 to v8 (MetaMask#46).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants