-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions of why the permissions are so extreme in chrome store description #48
Comments
👍 yeah, need to identify the correct places to do this |
Updated chrome store description to include this text:
|
danjm
pushed a commit
that referenced
this issue
Oct 6, 2020
The `retry` function has been extracted from the `useSwapSubmitFunction` hook. It has been replaced with an action creator, `navigateBackToBuildQuote`. One additional piece of state was cleared, the `approveTxId`. Normally this wouldn't be set in this circumstance, but if it was it would no longer be accurate, as it would represent the approval transaction for a quote that had been cleared from state.
danjm
pushed a commit
that referenced
this issue
Oct 6, 2020
The `retry` function has been extracted from the `useSwapSubmitFunction` hook. It has been replaced with an action creator, `navigateBackToBuildQuote`. One additional piece of state was cleared, the `approveTxId`. Normally this wouldn't be set in this circumstance, but if it was it would no longer be accurate, as it would represent the approval transaction for a quote that had been cleared from state.
aloisklink
pushed a commit
to aloisklink/metamask-extension
that referenced
this issue
Jan 19, 2022
This release includes various dependency updates and development tooling changes. The only functional change is the upgrade of `trezor-connect` from v7 to v8 (MetaMask#46).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This plugin requires about as scary-sounding permissions as a chrome extension can ask for, and that is almost definitely going to repulse some users.
What we can do to mitigate that effect is to document and be as transparent as possible about why we require those permissions.
The app store description is one place, I'm not sure if Chrome lets you explain on the permissions screen itself, but we should basically PR bomb why we require permissions as much as possible, so users are prepared for that authorization request.
The text was updated successfully, but these errors were encountered: