-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security alerts - We should run a new validation when transaction is edited on mobile #8382
Labels
Comments
seaona
added
type-bug
Something isn't working
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
labels
Jan 24, 2024
metamaskbot
added
the
regression-prod-7.15.0
Regression bug that was found in production in release 7.15.0
label
Jan 24, 2024
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Issues that have not had activity in the last 90 days
label
Apr 23, 2024
github-actions
bot
removed
the
stale
Issues that have not had activity in the last 90 days
label
Apr 24, 2024
bschorchit
removed
the
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
label
Jun 7, 2024
This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Issues that have not had activity in the last 90 days
label
Sep 5, 2024
bschorchit
changed the title
[Bug]: PPOM - Validation result is not updated when transaction is edited
Security alerts - Validation result is not updated when transaction is edited
Sep 5, 2024
bschorchit
changed the title
Security alerts - Validation result is not updated when transaction is edited
Security alerts - We should run a new validation when transaction is edited on mobile
Sep 5, 2024
bschorchit
added
type-enhancement
New feature or request
and removed
type-bug
Something isn't working
Sev2-normal
An issue that may lead to users misunderstanding some limited risks they are taking
regression-prod-7.15.0
Regression bug that was found in production in release 7.15.0
stale
Issues that have not had activity in the last 90 days
labels
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
Problem: same as in Extension, whenever we edit a transaction, the PPOM validation is not updated. A benign transaction could be malicious, if we change the amount of Approve/Send. However this won't be captured by the Blockaid warning, as it does not re-run the validation on Edit.
Expected behavior
Screenshots/Recordings
blockaid-malicious-validation-update.mp4
Steps to reproduce
Error messages or log output
No response
Version
7.15.0
Build type
None
Device
Pixel 6
Operating system
Android
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: