Make size report in bytes instead of number of entries when weighted. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| size = eviction.weightedSize().orElse(-1); | ||
| } else { | ||
| size = -1; | ||
| } |
There was a problem hiding this comment.
it's a bit weird to convert to optional to null to check if they're present. why not just check isPresent directly?
Alternatively you could go full functional and embrace the option style (although OptionalLong throws a bit of a wrench in here, because it's not Optional, in which case we could have used flatMap)
cache
.policy()
.eviction()
.map(eviction -> eviction.isWeighted() ? eviction.weightedSize() : OptionalLong.empty())
.orElse(OptionalLong.empty()).orElse(-1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently size is simply reported in number of entries, this makes the size report as the weight size, if a maximum size is specified.