typings, refactor #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
force-pushed
the
typings_and_slight_refactor
branch
from
277a2d1
to
7ac0ff9
Compare
|
fixes #10 |
changes: * refactor `ZookeeperLock` to extend `EventEmitter` instead of wrapping * use typings instead of tsd * use tsconfig.js instead of grunt to compile * bluebird instead of q * update locators
clintropolis
force-pushed
the
typings_and_slight_refactor
branch
from
7ac0ff9
to
d87f497
Compare
| "declaration": true | ||
| }, | ||
| "filesGlob": [ | ||
| "src/**/*.ts", |
There was a problem hiding this comment.
this should be src/*.ts i think.
UPDATE: i guess it doesnt matter
|
💸 |
|
sorry i totally forgot about this guy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
ZookeeperLockto extendEventEmitterinstead of wrapping