Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French SI Brochure feedback from BIPM (pages 41-60) #42

Closed
ronaldtse opened this issue Oct 30, 2020 · 12 comments
Closed

French SI Brochure feedback from BIPM (pages 41-60) #42

ronaldtse opened this issue Oct 30, 2020 · 12 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@ronaldtse
Copy link
Contributor

page comment
41 Wrong title. Replace "Le Système international d’unités Table des matières" by "Table des matières de l’annexe 1"
41 Entry for CIPM 1969: bad linebreak in second line
41 Entry for 23rd CGPM 2007:bad line break
42 Wrong title, remove
43 Wrong title, remove
43 Entry for CIPM 1946 : bad line break
43 Entry for CIPM 1988 : bad line break
43 9th CGPM 1948: bad line break
44 10th CGPM 1954: bad line break
44 Wrong title, remove
44 13th CGPM "K" not in italics
44 CIPM 1946: bad line break
45 Wrong title, remove
45 CIPM 1984: bad line break
45 Replace title "Unités supplémentaires page" by "Unités supplémentaires"
45 22nd CGPM 2003: bad line break
46 Wrong title, remove
46 12th CGPM 1964: bad line break
48 last side note: isolated « at end of line
49 Would be good if the first line could be on the previous page
50 paragraph below bullet point 3: replace "remarque" by "note"
51 side note:  isolated « at end of line
51 Table: μ not in italics
51 Table: dots before unit names little bit larger
51 Table, remarque 2: isolated « at end of line
54 last line : μ not in italics
54 table at bottom: larger space between first two columns
54 possible to have footnotes (4) nad (5) on page 55 ?
55 entry for volume: "mètre" belongs to the second column, not the first
55 table, last line: "cd/m2" too low
57 Curie (CR 94): the asterisk should be on Curie (CR94) not ont Resolution 7
58 side note of 13th CGPM 1967/68: attach this side note tothe definiton of the second in bullet point 1.
58 last side note: possible to have side note (1) on same page as corresponding text?
59 Resolution 5: isolated » at beginning of line
59 Resolution 5: last paragraph: no line break within numbers (2 x)
60 Resolution 6: μ not in italics
60 CIPM 1969, side note: isolated » at the beginning of line
60 Recommandation 1: replace "remarque" by "note"
@Intelligent2013
Copy link
Contributor

page comment to fix
41 Wrong title. Replace "Le Système international d’unités Table des matières" by "Table des matières de l’annexe 1" adoc
41 Entry for CIPM 1969: bad linebreak in second line adoc
41 Entry for 23rd CGPM 2007:bad line break adoc
42 Wrong title, remove adoc+xslt
43 Wrong title, remove adoc+xslt
43 Entry for CIPM 1946 : bad line break adoc
43 Entry for CIPM 1988 : bad line break adoc
43 9th CGPM 1948: bad line break adoc
44 10th CGPM 1954: bad line break adoc
44 Wrong title, remove adoc+xslt
44 13th CGPM "K" not in italics adoc
44 CIPM 1946: bad line break adoc
45 Wrong title, remove adoc+xslt
45 CIPM 1984: bad line break adoc
45 Replace title "Unités supplémentaires page" by "Unités supplémentaires" adoc
45 22nd CGPM 2003: bad line break adoc
46 Wrong title, remove adoc+xslt
46 12th CGPM 1964: bad line break adoc
48 last side note: isolated « at end of line adoc
49 Would be good if the first line could be on the previous page xslt?
50 paragraph below bullet point 3: replace "remarque" by "note" xslt
51 side note: isolated « at end of line adoc
51 Table: μ not in italics adoc
51 Table: dots before unit names little bit larger adoc (hex 2022)
51 Table, remarque 2: isolated « at end of line adoc
54 last line : μ not in italics adoc
54 table at bottom: larger space between first two columns ?
54 possible to have footnotes (4) nad (5) on page 55 ? not possible
55 entry for volume: "mètre" belongs to the second column, not the first adoc
55 table, last line: "cd/m2" too low xslt
57 Curie (CR 94): the asterisk should be on Curie (CR94) not ont Resolution 7 adoc
58 side note of 13th CGPM 1967/68: attach this side note tothe definiton of the second in bullet point 1. adoc
58 last side note: possible to have side note (1) on same page as corresponding text? not possible
59 Resolution 5: isolated » at beginning of line adoc
59 Resolution 5: last paragraph: no line break within numbers (2 x) adoc
60 Resolution 6: μ not in italics adoc
60 CIPM 1969, side note: isolated » at the beginning of line adoc
60 Recommandation 1: replace "remarque" by "note" xslt

@manuelfuenmayor
Copy link
Contributor

41 | Wrong title. Replace "Le Système international d’unités Table des matières" by "Table des matières de l’annexe 1" | adoc

Fixed.

41 | Entry for CIPM 1969: bad linebreak in second line | adoc

41 | Entry for 23rd CGPM 2007:bad line break | adoc

This happens because of the presence of a explicit linebreak in the markup.
All of them are now removed in ToC. Fixed.

42 | Wrong title, remove | adoc+xslt

43 | Wrong title, remove | adoc+xslt

44 | Wrong title, remove | adoc+xslt

45 | Wrong title, remove | adoc+xslt

46 | Wrong title, remove | adoc+xslt

Not a markup issue (I think).

43 | Entry for CIPM 1946 : bad line break | adoc

43 | Entry for CIPM 1988 : bad line break | adoc

43 | 9th CGPM 1948: bad line break | adoc

44 | 10th CGPM 1954: bad line break | adoc

Fixed. (All explicit linebreaks are removed in ToC.)

44 | 13th CGPM "K" not in italics | adoc

44 | CIPM 1946: bad line break | adoc

45 | CIPM 1984: bad line break | adoc

45 | Replace title "Unités supplémentaires page" by "Unités supplémentaires" | adoc

45 | 22nd CGPM 2003: bad line break | adoc

46 | 12th CGPM 1964: bad line break | adoc

48 | last side note: isolated « at end of line | adoc

51 | side note: isolated « at end of line | adoc

51 | Table: dots before unit names little bit larger | adoc (hex 2022)

51 | Table, remarque 2: isolated « at end of line | adoc

55 | entry for volume: "mètre" belongs to the second column, not the first | adoc

59 | Resolution 5: isolated » at beginning of line | adoc

60 | CIPM 1969, side note: isolated » at the beginning of line | adoc

All fixed.

51 | Table: μ not in italics | adoc

54 | last line : μ not in italics | adoc

60 | Resolution 6: μ not in italics | adoc

Not a markup issue.

54 | table at bottom: larger space between first two columns | ?

Not understading neither.

57 | Curie (CR 94): the asterisk should be on Curie (CR94) not ont Resolution 7 | adoc

58 | side note of 13th CGPM 1967/68: attach this side note tothe definiton of the second in bullet point 1. | adoc

The note block was misplaced. Fixed.

59 | Resolution 5: last paragraph: no line break within numbers (2 x) | adoc

This is suposed to be hadled automatically. Fixed.

@manuelfuenmayor
Copy link
Contributor

The fixes are in #45

@Intelligent2013
Copy link
Contributor

Regarding issues:

page comment to fix
42 Wrong title, remove adoc+xslt

The header Décisions concernant l’établissement du SI page repeats on each page:

изображение

because it is part of table header.

To repeat 'Page' only on each page I propose to move Décisions concernant l’établissement du SI page from header into table body. In this case we get:

изображение

Please note that Décisions concernant l’établissement du SI page and Page place on the different rows than in source PDF:

изображение

Is this is an acceptable solution?

@opoudjis
Copy link
Contributor

I don't have an objection. I mean, I have an blanket objection to BIPM's formatting, but not specifically to this. :-)

@manuelfuenmayor
Copy link
Contributor

manuelfuenmayor commented Dec 1, 2020

54 | table at bottom: larger space between first two columns | ?

54 | table at bottom: larger space between first two columns | ?
Not understading neither.

Ah! Now I see the problem in this case @Intelligent2013...

This is the table:

table1

First two columns: Facteur par lequel l’unité est multipliée and Préfixe are too close (probably because of the side note). They seem like one column.

Look:

table2

Like BIPM says, we need to make the space between them a little bit larger (just like columns 4 and 5).

@manuelfuenmayor
Copy link
Contributor

Based on the latest PDF provided by @opoudjis: si-brochure-fr(12-01).pdf

These are the issues that don't fulfill with BIPM requirements yet.

page comment issue
54 table at bottom: larger space between first two columns not fixed
54 possible to have footnotes (4) nad (5) on page 55 ? not fixed

@Intelligent2013
Copy link
Contributor

54 | table at bottom: larger space between first two columns | ?

I can't specify exactly width for columns. It calculated automatically.
But you can try to add an empty column with non-break space inside table cells. In this case, then resulted PDF will look:

изображение

54 | possible to have footnotes (4) nad (5) on page 55 ?

Possible. And it was made a month ago yet in one of previous versions. But in this case we've got a vertical gaps between paragraphs in some case, because sometimes the height of margin note is higher than height of paragraph.

@manuelfuenmayor
Copy link
Contributor

manuelfuenmayor commented Dec 2, 2020

I can't specify exactly width for columns. It calculated automatically.
But you can try to add an empty column with non-break space inside table cells. In this case, then resulted PDF will look:

@Intelligent2013 this turns out to be a markup problem. I had set the column alignment to right in the first column and to the left in second column ([cols=">,<,^,>,^,^"]). Of course they will look stuck to each other. I have fixed it in #59:

Capture2

I'm sorry I've bothered you with this.

@manuelfuenmayor
Copy link
Contributor

One issue left in this thread:

54 | possible to have footnotes (4) nad (5) on page 55 ? | not fixed

Possible. And it was made a month ago yet in one of previous versions. But in this case we've got a vertical gaps between paragraphs in some case, because sometimes the height of margin note is higher than height of paragraph.

@anermina
Copy link
Contributor

anermina commented Dec 8, 2020

@manuel489 @Intelligent2013 Are there any actions that we should take regarding the footnotes mentioned in the previous comment? In case not, please close this ticket.

@manuelfuenmayor manuelfuenmayor moved this from In progress to On hold in Editing Dec 9, 2020
@Intelligent2013
Copy link
Contributor

There aren't more actions from me. Closing.

Editing automation moved this from On hold to Done Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Editing
  
Done
Development

No branches or pull requests

5 participants