Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up metanorma new related functionality and tests #42

Closed
ronaldtse opened this issue Apr 15, 2019 · 5 comments
Closed

Clean up metanorma new related functionality and tests #42

ronaldtse opened this issue Apr 15, 2019 · 5 comments
Assignees
@abunashir
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

Comments from review

Is this fixed?
@ronaldtse ronaldtse added the bug Something isn't working label Apr 15, 2019
@abunashir
Copy link
Member

abunashir commented Apr 21, 2019 •
edited

Done

  • Customized thor's default error messages
  • Do not create directory from Travis CI
  • Re-Structure the newly created document

cc: @ronaldtse

@opoudjis
Copy link
Contributor

I've had a request from @CAMOBAP795 to expedite release of metanorma-cli, to address Appveyor issues with Windows deployment. @abunashir please let me know when metanorma-cli is ready to go.

@abunashir
Copy link
Member

The pending changes are done in the open pull request, once it's merged then we should have those functionalities in the CLI, the appvayor tests are still the same, so I would leave to Ron to decide.

cc: @ronaldtse, @opoudjis

@ronaldtse
Copy link
Contributor Author

Remaining issues detailed in #43

@ronaldtse
Copy link
Contributor Author

#43 has merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abunashir abunashir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronaldtse @abunashir @opoudjis