Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diff/zero_order): add new parameter num_samples #111

Merged
merged 21 commits into from
Dec 5, 2022

Conversation

JieRen98
Copy link
Collaborator

@JieRen98 JieRen98 commented Nov 7, 2022

No description provided.

@Benjamin-eecs Benjamin-eecs added this to the 0.7.0 milestone Nov 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Base: 64.67% // Head: 64.02% // Decreases project coverage by -0.65% ⚠️

Coverage data is based on head (ec288cc) compared to base (05e0f3f).
Patch coverage: 34.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   64.67%   64.02%   -0.66%     
==========================================
  Files          66       69       +3     
  Lines        2828     2910      +82     
==========================================
+ Hits         1829     1863      +34     
- Misses        999     1047      +48     
Flag Coverage Δ
unittests 64.02% <34.21%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/diff/zero_order/decorator.py 7.42% <8.51%> (ø)
torchopt/diff/zero_order/nn/module.py 55.55% <55.55%> (ø)
torchopt/typing.py 95.45% <90.00%> (-1.61%) ⬇️
torchopt/diff/zero_order/__init__.py 92.30% <92.30%> (ø)
torchopt/diff/__init__.py 100.00% <100.00%> (ø)
torchopt/diff/zero_order/nn/__init__.py 100.00% <100.00%> (ø)
torchopt/nn/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan changed the title feat(zero_grad): add new parameter sample_num feat(diff/zero_order): add new parameter num_samples Nov 9, 2022
@XuehaiPan XuehaiPan added enhancement New feature or request feature New feature labels Nov 16, 2022
@XuehaiPan XuehaiPan force-pushed the zero_grad branch 2 times, most recently from 13e1a0d to a291187 Compare November 19, 2022 12:10
XuehaiPan
XuehaiPan previously approved these changes Dec 5, 2022
@XuehaiPan XuehaiPan merged commit 8ef1bea into metaopt:main Dec 5, 2022
@XuehaiPan XuehaiPan deleted the zero_grad branch December 5, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants