Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize Dockerfile #53

Closed
radu-matei opened this issue Dec 20, 2017 · 4 comments
Closed

Ability to customize Dockerfile #53

radu-matei opened this issue Dec 20, 2017 · 4 comments

Comments

@radu-matei
Copy link
Contributor

radu-matei commented Dec 20, 2017

Briefly mentioned this in #50, but I think it deserves its own issue.

Right now as I looked around the packaging, when writing an application you cannot customize the Dockerfile in any way - would it make sense to allow it as a parameter?

I am not saying it should be default, but once the needs of the service overcome what is included in the basic Dockerfile for each runtime, then it might be useful to allow (either in code or as separate file) to come with your own Dockerfile.

Looking at #2 - does it only refer to adding files from the project?
How would you handle external deps?

Radu M

@stealthybox
Copy link
Contributor

related: #51
java/js/python/dotnet now support copying a dockerfile from somewhere on the file system.

@stealthybox
Copy link
Contributor

/cc @brendanburns

@brendandburns
Copy link
Contributor

yeah #51 should address this.

re #2 thats to pull in other files (eg static html, etc)

@brendandburns
Copy link
Contributor

Closing this since #51 covers this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants