Adding Rubygem for Ruby Applications #21
Conversation
christopherhein
force-pushed
the
feature/add-ruby-mechanisms
branch
2 times, most recently
from
394938d
to
536bc0e
Compare
ruby/metaparticle/CODE_OF_CONDUCT.md
Outdated
| @@ -0,0 +1,74 @@ | |||
| # Contributor Covenant Code of Conduct | |||
There was a problem hiding this comment.
I'd like to add a code of conduct to the overall repository, and I'd like to use the Microsoft CoC:
https://opensource.microsoft.com/codeofconduct/
Let's do this as a separate PR?
ruby/metaparticle/LICENSE.txt
Outdated
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
There was a problem hiding this comment.
I'd like to have a single LICENSE at the top, rather than a lower-level one in a language implemenation. Hope that makes sense...
ruby/metaparticle/README.md
Outdated
|
|
||
| ## Contributing | ||
|
|
||
| Bug reports and pull requests are welcome on GitHub at https://github.com/christopherhein/metaparticle. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct. |
There was a problem hiding this comment.
Change to point to the https://github.com/metaparticle-io/package repo.
Delete the code of conduct part given we'll add it in a separate PR for the whole repo.
ruby/metaparticle/README.md
Outdated
|
|
||
| ## Code of Conduct | ||
|
|
||
| Everyone interacting in the Metaparticle project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/christopherhein/metaparticle/blob/master/CODE_OF_CONDUCT.md). |
There was a problem hiding this comment.
Let's delete and add these as part of the Code of Conduct PR (or wait to merge this, and redirect it)
|
@christopherhein thanks for the PR, I had a few comments... |
christopherhein
force-pushed
the
feature/add-ruby-mechanisms
branch
2 times, most recently
from
feeb9a0
to
13ec2c9
Compare
|
@brendandburns addressed the current feedback, thank you! |
**Why:** * Currently tested to run a `sinatra` application * Uses the same `mp-compiler` to build out the specs * Uses an `alpine` image out of the box to run
christopherhein
force-pushed
the
feature/add-ruby-mechanisms
branch
from
13ec2c9
to
e87b5cd
Compare
|
LGTM thanks! |
**Why:** * Currently tested to run a `sinatra` application * Uses the same `mp-compiler` to build out the specs * Uses an `alpine` image out of the box to run
Why:
sinatraapplicationmp-compilerto build out the specsalpineimage out of the box to runTodo:
gemto allow you to run without ports definedResolves #8