Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: auction house listing asset error SaleRequiresExactlyOneSigner #1049

Open
boredjoker opened this issue Mar 12, 2023 · 6 comments
Open
Labels

Comments

@boredjoker
Copy link

boredjoker commented Mar 12, 2023

Which package is this bug report for?

auction-house

Which Type of Package is this bug report for?

Rust Contract

Issue description

when auction house requires_sign_off is true, how can we listing a asset by user, signing with authority,and send transaction by user(as fee payer),why can't we let user and authority as both signer like last version?

  1. last version success transaction

  2. new version error transaction
    Error Code: SaleRequiresExactlyOneSigner. Error Number: 6044. Error Message: This sale requires exactly one signer: either the seller or the authority..

  3. new version error without authority sign transaction
    Error Code: CannotTakeThisActionWithoutAuctionHouseSignOff. Error Number: 6011. Error Message: Cannot take this action without auction house signing too.

Relevant log output

No response

Priority this issue should have

High (immediate attention needed)

@boredjoker boredjoker added the bug label Mar 12, 2023
@carriekellar
Copy link

Hey we're getting the same error! Any update on this?

@jdnichollsc
Copy link

Hello @samuelvanderwaal, do you need more details about this error? Thanks for your help, please let us know how can we help! <3

@samuelvanderwaal
Copy link
Contributor

@boredjoker @carrie-hk @jdnichollsc hey everyone, I'm opening a PR to remove the double signer restriction as there does not appear to be a good reason to keep that in place. Keep in mind that the fee payer still defaults to the auction house fee account with two signers and it's out of scope to refactor this as it affects more than just this handler. However, to work around this you can include a simple system transfer instruction from the user to the auction house fee account if you want the user to pay for the creation of the trade state account.

@carriekellar
Copy link

Also @samuelvanderwaal there's a version mismatch on the deployed program see here. It should be v1.4.0, but says v1.3.4

@carriekellar
Copy link

This problem isn't in v1.3.4, but when we're calling on devnet we are facing this error! Not too sure what's up there -- maybe an IDL mismatch?

@samuelvanderwaal
Copy link
Contributor

This problem isn't in v1.3.4, but when we're calling on devnet we are facing this error! Not too sure what's up there -- maybe an IDL mismatch?

Yeah probably just an IDL mismatch. I will bump versions and redeploy to both devnet and mainnet today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants