Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github workflow for API docs publishing #151

Merged
merged 2 commits into from Jan 19, 2022
Merged

fix: github workflow for API docs publishing #151

merged 2 commits into from Jan 19, 2022

Conversation

aheckmann
Copy link
Contributor

@thlorenz
Copy link
Contributor

I don't understand why this docs/.gitkeep is needed at all.
I have docs/ in my .gitignore and then I just force the docs to be added in the update docs script.
See the beet example.

That way docs can be there or not but never get checked in ( the folder is not required as tsdoc gens it if it's not there).

thlorenz
thlorenz approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@thlorenz thlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming that gh-pages tool knows to force add the docs folder to git.

@aheckmann aheckmann merged commit 897e756 into main Jan 19, 2022
@aheckmann aheckmann deleted the fix_docs_generation branch January 19, 2022 21:50
@zaxozhu
Copy link
Contributor

zaxozhu commented Jan 19, 2022

🎉 This PR is included in version 4.11.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thlorenz thlorenz thlorenz approved these changes

Assignees
No one assigned
Labels
SDK: JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aheckmann @thlorenz @zaxozhu