feat: close vault action #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2kdaman
force-pushed
the
feat/vault-closeVault
branch
from
8f84d48
to
e37872c
Compare
zaxozhu
previously approved these changes
Dec 1, 2021
kurpav
suggested changes
Dec 2, 2021
b2kdaman
force-pushed
the
feat/vault-closeVault
branch
from
e37872c
to
e35e5fc
Compare
added 4 commits
December 2, 2021 10:44
Checklist update feat: close vault action update tests fix: lint fix
removed axios and magic numbers
kurpav
approved these changes
Dec 2, 2021
austbot
reviewed
Dec 2, 2021
| const redeemTreasuryKey = new PublicKey(redeemTreasury); | ||
| const pricingLookupAddressKey = new PublicKey(pricingLookupAddress); | ||
|
|
||
| const activateVaultTx = new ActivateVault(txOptions, { |
There was a problem hiding this comment.
why do you activate in the close command?
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist update