Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MemoryWritable stream #291

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Implement MemoryWritable stream #291

merged 1 commit into from
Jun 18, 2019

Conversation

belochub
Copy link
Member

@belochub belochub commented May 23, 2019

MemoryWritable allows to pipe the data from the readable stream into memory.

  • code is properly formatted (npm run fmt)
  • tests are added/updated
  • documentation is updated (npm run doc to regenerate documentation based on comments)
  • description of changes is added under the Unreleased header in CHANGELOG.md

I will update documentation after metarhia/metadoc#58 is resolved.

@belochub belochub added functionality semver-minor addition of functionality in a backwards-compatible manner labels May 23, 2019
@belochub belochub requested a review from lundibundi May 23, 2019 11:51
@belochub belochub self-assigned this May 23, 2019
@belochub
Copy link
Member Author

Ping @lundibundi.

lib/stream.js Outdated Show resolved Hide resolved
It allows to pipe the data from the readable stream into memory.

PR-URL: #291
@belochub belochub merged commit 160e948 into master Jun 18, 2019
@belochub belochub deleted the memory-writable-stream branch June 18, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functionality semver-minor addition of functionality in a backwards-compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants