Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple updates to SelectBuilder and PostgresCursor #285

Merged
merged 3 commits into from
Nov 29, 2018
Merged

Multiple updates to SelectBuilder and PostgresCursor #285

merged 3 commits into from
Nov 29, 2018

Conversation

lundibundi
Copy link
Member

  • support multiple tables in 'FROM'
  • proper complex key escaping (i.e. table.field)
  • support for innerJoin
  • support for Include category in PostgresCursor

@lundibundi lundibundi self-assigned this Nov 28, 2018
lundibundi
lundibundi commented Nov 29, 2018
View reviewed changes
lib/pg.utils.js Outdated
@@ -136,6 +137,23 @@ const buildWhere = query => {
}).join(' AND '), params];
};

const expand = (object, schema) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't 'expand' the object, it actually 'compacts' it. I think it'd be better to name it fitToSchema or frameInSchema etc?

lundibundi
lundibundi commented Nov 29, 2018
View reviewed changes
Copy link
Member Author

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @belochub and @nechaido changes.

@belochub belochub changed the title WiP: Multiple updates to SelectBuilder and PostgresCursor Multiple updates to SelectBuilder and PostgresCursor Nov 29, 2018
lundibundi and others added 3 commits November 30, 2018 00:59
@lundibundi @belochub
Multiple updates to SelectBuilder and PostgresCursor
fc2a279 
* support multiple tables in 'FROM'
* proper complex key escaping (i.e. table.field)
* support for innerJoin
* support for Include category in PostgresCursor

PR-URL: #285

Co-authored-by: Mykola Bilochub <nbelochub@gmail.com>
@belochub @nechaido
Add test for Include category support in PostgresCursor
6f4dc29 
PR-URL: #285

Co-authored-by: Dmytro Nechai <nechaido@gmail.com>
@nechaido @belochub
Restore object structure after select with join
4666083 
PR-URL: #285
@belochub belochub merged commit 4666083 into master Nov 29, 2018
@nechaido nechaido deleted the pg-cursor-updates branch March 20, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nechaido nechaido nechaido approved these changes

Assignees

@lundibundi lundibundi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lundibundi @nechaido @belochub