Add new parameter to cy.executeQuickAction: isDialogExpected if a…

… modal dialog is expected when executing the action.

#248

cypress/support/commands/action.js

@@ -41,7 +41,7 @@ Cypress.Commands.add('executeHeaderActionWithDialog', actionName => {
   });
 });
 
-Cypress.Commands.add('executeQuickAction', (actionName, defaultAction = false, modal = false) => {
+Cypress.Commands.add('executeQuickAction', (actionName, defaultAction = false, modal = false, isDialogExpected = true) => {
   let path = `.quick-actions-wrapper`; // default action
   const requestAlias = `quickAction-${actionName}-${humanReadableNow()}`;
 
@@ -65,8 +65,13 @@ Cypress.Commands.add('executeQuickAction', (actionName, defaultAction = false, m
     .should('not.have.class', 'quick-actions-item-disabled')
     .get(path)
     .click({ timeout: 10000 })
-    .get('.panel-modal', { timeout: 10000 }) // wait up to 10 secs for the modal to appear
-    .should('exist');
+    .then(el => {
+      if (isDialogExpected) {
+        cy.wrap(el)
+          .get('.panel-modal', { timeout: 10000 }) // wait up to 10 secs for the modal to appear
+          .should('exist');
+      }
+    });
 
   if (!defaultAction) {
     cy.wait(`@${requestAlias}`);

cypress/support/index.d.ts

@@ -29,8 +29,9 @@ declare namespace Cypress {
      * @param actionName - internal name of the action to be executed
      * @param defaultAction - optional, default false - if truthy the default action will be executed.
      * @param modal - optional, default = false - use true if the field is in a modal overlay; required if the underlying window has a field with the same name.
+     * @param isDialogExpected - optional, default true - use false if this action does not open any dialog
      */
-    executeQuickAction(actionName: string, defaultAction?: boolean, modal?: boolean): Chainable<any>
+    executeQuickAction(actionName: string, defaultAction?: boolean, modal?: boolean, isDialogExpected ?: boolean): Chainable<any>
 
     /**
      * @param fieldName - name of the field is question