metasfresh · cristinastefan90 · Aug 20, 2019 · Aug 8, 2019 · Aug 9, 2019 · Aug 19, 2019
diff --git a/cypress/integration/contracts/flatrate_conditions_material_tracking_spec.js b/cypress/integration/contracts/flatrate_conditions_material_tracking_spec.js
@@ -85,7 +85,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
 
@@ -97,7 +96,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(scrapProductName)
-        .setValue(scrapProductName)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -106,7 +104,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(processingFeeProductName)
-        .setValue(processingFeeProductName)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -115,7 +112,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productionProductName)
-        .setValue(productionProductName)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -124,7 +120,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(witholdingProductName)
-        .setValue(witholdingProductName)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -157,7 +152,6 @@ describe('Create material tracking contract conditions', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(rawProductName)
-        .setValue(rawProductName)
         .setProductType('Item')
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)

diff --git a/cypress/integration/inventory/create_disposal_from_handling_unit_editor.js b/cypress/integration/inventory/create_disposal_from_handling_unit_editor.js
@@ -41,7 +41,6 @@ describe('Create a single HU', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productName)
         .apply();
     });
   });

diff --git a/cypress/integration/inventory/inventory_aggregatedHUs_spec.js b/cypress/integration/inventory/inventory_aggregatedHUs_spec.js
@@ -14,7 +14,6 @@ describe('Aggregated-HUs inventory test', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .apply();
     });
   });

diff --git a/cypress/integration/inventory/inventory_singleHU_spec.js b/cypress/integration/inventory/inventory_singleHU_spec.js
@@ -16,7 +16,6 @@ describe('Create a single HU', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productName)
         .apply();
     });
   });

diff --git a/cypress/integration/logistics/create_new_packing_instructions_spec.js b/cypress/integration/logistics/create_new_packing_instructions_spec.js
@@ -15,7 +15,6 @@ describe('create new packing instructions ', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
 

diff --git a/cypress/integration/logistics/materialentnahme_complete_HU.js b/cypress/integration/logistics/materialentnahme_complete_HU.js
@@ -65,7 +65,6 @@ describe('Change warehouse to Materialentnahmelager', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
   });

diff --git a/cypress/integration/masterdata/discountschema_with_breaks_spec.js b/cypress/integration/masterdata/discountschema_with_breaks_spec.js
@@ -10,14 +10,12 @@ describe('New discount schema Test', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
 
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productName)
         .setProductType('Service')
         .apply();
     });

diff --git a/cypress/integration/materialReceipt/create_material_receipt_with_quality_issue.js b/cypress/integration/materialReceipt/create_material_receipt_with_quality_issue.js
@@ -84,7 +84,6 @@ describe('Create material receipt with quality issue', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
   });

diff --git a/cypress/integration/price/change_product_prices_and_add_a_new_one.js b/cypress/integration/price/change_product_prices_and_add_a_new_one.js
@@ -117,7 +117,6 @@ describe('Create the 3 products ', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName1)
-        .setValue(productName1)
         .setProductType(productType)
         .setProductCategory(productCategoryName1)
         .addCUTUAllocation(packingInstructionsName1)
@@ -129,7 +128,6 @@ describe('Create the 3 products ', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName2)
-        .setValue(productName2)
         .setProductType(productType)
         .setProductCategory(productCategoryName1)
         .addCUTUAllocation(packingInstructionsName1)
@@ -142,7 +140,6 @@ describe('Create the 3 products ', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName3)
-        .setValue(productName3)
         .setProductType(productType)
         .setProductCategory(productCategoryName2)
         .addCUTUAllocation(packingInstructionsName1)
@@ -231,7 +228,6 @@ function createProductCategory(productCategoryName, attributeSet) {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .setAttributeSet(attributeSet)
         .apply();
     });

diff --git a/cypress/integration/product/change_product_price_spec.js b/cypress/integration/product/change_product_price_spec.js
@@ -21,7 +21,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
   });
@@ -37,7 +36,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
         .setSold(false)

diff --git a/cypress/integration/product/create_bill_of_material.js b/cypress/integration/product/create_bill_of_material.js
@@ -17,7 +17,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
   });
@@ -28,7 +27,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .setStocked(true)
         .setPurchased(true)
@@ -44,7 +42,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productComponentName)
-        .setValue(productComponentValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .setStocked(true)
         .setPurchased(true)

diff --git a/cypress/integration/product/product_for_procurement_contracts.js b/cypress/integration/product/product_for_procurement_contracts.js
@@ -13,7 +13,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
   });
@@ -22,7 +21,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .setStocked(true)
         .setPurchased(true)

diff --git a/cypress/integration/product/product_packing_item_setup.js b/cypress/integration/product/product_packing_item_setup.js
@@ -12,7 +12,6 @@ describe('Create Test: set packing item in product window https://github.com/met
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
   });
@@ -21,7 +20,6 @@ describe('Create Test: set packing item in product window https://github.com/met
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .apply();
     });

diff --git a/cypress/integration/product/productcategory_product_setup_spec.js b/cypress/integration/product/productcategory_product_setup_spec.js
@@ -13,7 +13,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
   });
@@ -22,7 +21,6 @@ describe('Create Product', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .apply();
     });

diff --git a/cypress/integration/purchase/purchase_order_complete_change_complete.js b/cypress/integration/purchase/purchase_order_complete_change_complete.js
@@ -66,7 +66,6 @@ describe('Create Purchase order - complete - change - complete', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
 

diff --git a/cypress/integration/purchase/purchase_order_complete_reactivate_complete.js b/cypress/integration/purchase/purchase_order_complete_reactivate_complete.js
@@ -68,7 +68,6 @@ describe('Create Purchase order - complete - reactivate - complete', function()
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
 

diff --git a/cypress/integration/purchase/purchase_order_from_sales_order.js b/cypress/integration/purchase/purchase_order_from_sales_order.js
@@ -44,7 +44,6 @@ describe('Create Purchase order from sales order', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productForPackingMaterial)
-        .setValue(productForPackingMaterial)
         .setProductType(productType)
         .setProductCategory('24_Gebinde')
         .addProductPrice(productPricePM1)
@@ -76,7 +75,6 @@ describe('Create Purchase order from sales order', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
     /**Create vendor to use in product - Business partner tab - current vendor */
@@ -112,7 +110,6 @@ describe('Create Purchase order from sales order', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName1)
-        .setValue(productName1)
         .setProductType(productType)
         .setProductCategory(productCategoryName + '_' + productCategoryName)
         .addProductPrice(productPrice1)

diff --git a/cypress/integration/purchase/purchase_order_material_receipt_invoice.js b/cypress/integration/purchase/purchase_order_material_receipt_invoice.js
@@ -67,7 +67,6 @@ describe('Create test data', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
   });

diff --git a/cypress/integration/warehouse/create_new_stock_control_purchase_spec.js b/cypress/integration/warehouse/create_new_stock_control_purchase_spec.js
@@ -23,7 +23,6 @@ describe('Create new Stock Control Purchase', function() {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryName)
         .apply();
     });
 
@@ -36,7 +35,6 @@ describe('Create new Stock Control Purchase', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName1)
-        .setValue(productName1)
         .setProductType(productType)
         .setProductCategory(productCategoryName + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -48,7 +46,6 @@ describe('Create new Stock Control Purchase', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName2)
-        .setValue(productName2)
         .setProductType(productType)
         .setProductCategory(productCategoryName + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -60,7 +57,6 @@ describe('Create new Stock Control Purchase', function() {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName3)
-        .setValue(productName3)
         .setProductType(productType)
         .setProductCategory(productCategoryName + '_' + productCategoryName)
         .addProductPrice(productPrice)

diff --git a/cypress/support/utils/builder.js b/cypress/support/utils/builder.js
@@ -50,7 +50,6 @@ export class Builder {
     cy.fixture('product/simple_productCategory.json').then(productCategoryJson => {
       Object.assign(new ProductCategory(), productCategoryJson)
         .setName(productCategoryName)
-        .setValue(productCategoryValue)
         .apply();
     });
 
@@ -62,7 +61,6 @@ export class Builder {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -87,7 +85,6 @@ export class Builder {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductType(productType)
         .setProductCategory(productCategoryValue + '_' + productCategoryName)
         .addProductPrice(productPrice)
@@ -111,7 +108,6 @@ export class Builder {
     cy.fixture('product/simple_product.json').then(productJson => {
       Object.assign(new Product(), productJson)
         .setName(productName)
-        .setValue(productValue)
         .setProductType(productType)
         .setProductCategory(categoryName)
         .addProductPrice(productPrice)

diff --git a/cypress/support/utils/product.js b/cypress/support/utils/product.js
@@ -17,12 +17,6 @@ export class Product {
     return this;
   }
 
-  setValue(value) {
-    cy.log(`Product value is never used`);
-    this.value = value;
-    return this;
-  }
-
   setDescription(description) {
     cy.log(`Product - set description = ${description}`);
     this.description = description;
@@ -203,12 +197,6 @@ export class ProductCategory {
     return this;
   }
 
-  setValue(value) {
-    cy.log(`Product Category - set value = ${value}`);
-    this.value = value;
-    return this;
-  }
-
   setAttributeSet(attributeSet) {
     cy.log(`Product Category - set attributeSet = ${attributeSet}`);
     this.attributeSet = attributeSet;
@@ -226,8 +214,7 @@ export class ProductCategory {
     cy.visitWindow('144', 'NEW');
     cy.writeIntoStringField('Name', productCategory.name);
 
-    // Value can be updated
-    cy.writeIntoStringField('Value', productCategory.value);
+    cy.writeIntoStringField('Value', productCategory.name);
     if (productCategory.attributeSet) {
       cy.selectInListField('M_AttributeSet_ID', productCategory.attributeSet);
     }